Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ [#2562] Bump lxml and xmlsec to their latest versions #1261

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

sergei-maertens
Copy link
Member

xmlsec has done efforts to support binary wheels together with lxml to avoid compile/installation/runtime issues, which should also speed up installation since no source compilation is required.

Commit message from eeac088:

Several teammembers have faced sporadic issues installing xmlsec due to missing binaries and the resulting difficulties in building the packages with the right library versions. Requiring at least 1.3.14 allows us to use the pre-built binaries.

xmlsec has done efforts to support binary wheels together with lxml
to avoid compile/installation/runtime issues, which should also speed
up installation since no source compilation is required.

Commit message from eeac088:

Several teammembers have faced sporadic issues installing xmlsec
due to missing binaries and the resulting difficulties in
building the packages with the right library versions. Requiring
at least 1.3.14 allows us to use the pre-built binaries.
@alextreme alextreme merged commit 701b402 into develop Jun 18, 2024
18 checks passed
@alextreme alextreme deleted the chore/bump-lxml-xmlsec branch June 18, 2024 08:12
@alextreme
Copy link
Member

The lxml upgrade is causing problems with our uwsgi-installs ( e.g. https://stackoverflow.com/questions/78582042/how-to-solve-the-xmlsec-error-100-lxml-xmlsec-libxml2-library-version-mism ). Requesting @swrichards to revert this PR for the time being as in my eyes the upgrade is currently causing more problems that it solves, I'd prefer to wait with upgrading lxml until the installation hassles are ironed out

@swrichards
Copy link
Contributor

The lxml upgrade is causing problems with our uwsgi-installs ( e.g. https://stackoverflow.com/questions/78582042/how-to-solve-the-xmlsec-error-100-lxml-xmlsec-libxml2-library-version-mism ). Requesting @swrichards to revert this PR for the time being as in my eyes the upgrade is currently causing more problems that it solves, I'd prefer to wait with upgrading lxml until the installation hassles are ironed out

See #1279 .

@sergei-maertens
Copy link
Member Author

sergei-maertens commented Jun 25, 2024

I managed to pinpoint it to the presence of the libxml2-dev package in Open Formulieren: open-formulieren/open-forms@8e06944

I don't know what in uwsgi causes this to go wrong, but this setup works for us with binary wheel installations. Other workarounds are indeed reverting back to source builds for both xmlsec and lxml, which should only remove the benefit of slower dependency installations.

If you have libxml2-dev on the server while installing uwsgi (which builds/compiles it during installation!), things break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants