Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♿ [#2347] Add table-TH style/markup for product pages #1258

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Jun 13, 2024

issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/2347

this issue is about the HTML structure.

Note: design in this issue is not important and will probably change later, this just contains a rudimentary set-up to make better changes possible for the future and some sad code needed to be refactored.

@jiromaykin jiromaykin added the wip Work in progress label Jun 13, 2024
@jiromaykin jiromaykin changed the title [#2352] Add table-header styles for product pages ♿ [#2352] Add table-header styles for product pages Jun 13, 2024
@jiromaykin jiromaykin added the Accessibility Improving accessibility label Jun 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 95.18%. Comparing base (dedbd14) to head (c2f9332).
Report is 6 commits behind head on develop.

Files Patch % Lines
src/open_inwoner/utils/ckeditor.py 27.27% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1258      +/-   ##
===========================================
- Coverage    95.20%   95.18%   -0.03%     
===========================================
  Files          978      978              
  Lines        35603    35614      +11     
===========================================
+ Hits         33896    33899       +3     
- Misses        1707     1715       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin changed the title ♿ [#2352] Add table-header styles for product pages ♿ [#2352] Add table-TH style/markup for product pages Jun 17, 2024
@jiromaykin jiromaykin force-pushed the issue/2347-A11y-1.3.1-table-heading-ckeditor branch 2 times, most recently from ac24032 to 446fa1f Compare June 17, 2024 09:05
@jiromaykin jiromaykin removed the wip Work in progress label Jun 17, 2024
@jiromaykin jiromaykin assigned pi-sigma and jiromaykin and unassigned pi-sigma Jun 17, 2024
@jiromaykin jiromaykin force-pushed the issue/2347-A11y-1.3.1-table-heading-ckeditor branch 3 times, most recently from 8b48792 to 005b718 Compare June 17, 2024 14:15
@jiromaykin jiromaykin changed the title ♿ [#2352] Add table-TH style/markup for product pages ♿ [#2347] Add table-TH style/markup for product pages Jun 17, 2024
@jiromaykin jiromaykin force-pushed the issue/2347-A11y-1.3.1-table-heading-ckeditor branch from 366f5e0 to 1f088f1 Compare June 17, 2024 14:49
@jiromaykin jiromaykin force-pushed the issue/2347-A11y-1.3.1-table-heading-ckeditor branch from edc62e0 to c2f9332 Compare June 17, 2024 14:57
@jiromaykin jiromaykin marked this pull request as ready for review June 17, 2024 14:59
@jiromaykin jiromaykin requested a review from pi-sigma June 17, 2024 15:38
@alextreme alextreme merged commit f43fb17 into develop Jun 18, 2024
16 checks passed
@alextreme alextreme deleted the issue/2347-A11y-1.3.1-table-heading-ckeditor branch June 18, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Improving accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants