♿ [#2352] Set meaningful order in cards with status-indicator #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1256 +/- ##
========================================
Coverage 95.22% 95.22%
========================================
Files 974 974
Lines 35471 35471
========================================
Hits 33778 33778
Misses 1693 1693 ☔ View full report in Codecov by Sentry. |
jiromaykin
force-pushed
the
issue/2352-A11y-1.3.2-status-indicator-card-hierarchy
branch
from
9872b8c
to
ae68407
Compare
pi-sigma
approved these changes
Jun 17, 2024
alextreme
deleted the
issue/2352-A11y-1.3.2-status-indicator-card-hierarchy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2352
Meaningful sequence for accessibility: any text belonging to a heading must be below the heading
Also corrected faulty build of this Card: the entire card needs to be an anchor, including the spacing/padding.
Which means an extra complication when there is an element that needs to be independent from the other padding (the colored status indicator headers), therefore setting padding to each element inside the card body, which also influences the Grid.