Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2266] Add setup for siteconfiguration #1140

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Apr 5, 2024

Taiga: #2266

@pi-sigma pi-sigma marked this pull request as ready for review April 8, 2024 09:18
@pi-sigma pi-sigma force-pushed the feature/2266-general-config-auto branch 2 times, most recently from 57c00a7 to 085465d Compare April 8, 2024 09:29
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 99.47368% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.10%. Comparing base (b4ab120) to head (f0ef803).
Report is 14 commits behind head on develop.

Files Patch % Lines
...pen_inwoner/configurations/bootstrap/siteconfig.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1140      +/-   ##
===========================================
+ Coverage    95.06%   95.10%   +0.04%     
===========================================
  Files          940      950      +10     
  Lines        33155    33737     +582     
===========================================
+ Hits         31518    32086     +568     
- Misses        1637     1651      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma force-pushed the feature/2266-general-config-auto branch from 085465d to 6d713b2 Compare April 8, 2024 10:26
@pi-sigma pi-sigma requested a review from stevenbal April 9, 2024 09:48
@pi-sigma pi-sigma marked this pull request as draft April 9, 2024 13:14
@pi-sigma pi-sigma marked this pull request as ready for review April 9, 2024 13:17
@pi-sigma pi-sigma force-pushed the feature/2266-general-config-auto branch from f1fb73d to f0ef803 Compare April 11, 2024 10:20
@pi-sigma pi-sigma force-pushed the feature/2266-general-config-auto branch from f0ef803 to 1a7e52b Compare April 11, 2024 12:16
@pi-sigma pi-sigma marked this pull request as draft April 11, 2024 12:17
@pi-sigma pi-sigma force-pushed the feature/2266-general-config-auto branch from 1a7e52b to 94a2f04 Compare April 11, 2024 12:21
@pi-sigma pi-sigma force-pushed the feature/2266-general-config-auto branch from 94a2f04 to 35c53be Compare April 11, 2024 13:06
@pi-sigma pi-sigma requested a review from stevenbal April 11, 2024 15:01
@pi-sigma pi-sigma marked this pull request as ready for review April 12, 2024 07:18
@stevenbal stevenbal merged commit 1226f36 into develop Apr 12, 2024
15 checks passed
@stevenbal stevenbal deleted the feature/2266-general-config-auto branch April 12, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants