✨ [#2149] Display new answer header for mijn vragen list

[stevenbal]

task: https://taiga.maykinmedia.nl/project/open-inwoner/task/2149

This can be tested locally by connecting to the mock Klanten/Contactmomenten endpoints:

• http://localhost:8000/apimock/openklant-read/klanten/
• http://localhost:8000/apimock/openklant-read/contactmomenten/

Logging in with DigiD and navigating to Mijn vragen, this should should the new answer header for the vraag, which should disappear after visiting the detail page

[Bartvaderkin]

Preliminary review as I'm only here in the morning.

I note you removed some of the apimocks. I don't mind and I assume there is a good reason and Paul and Jiro don't need them (I heard they actually would like more for proper list development but that could be for another time)

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.02%. Comparing base (bbe2ddb) to head (2a54eda).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1075      +/-   ##
===========================================
+ Coverage    95.00%   95.02%   +0.01%     
===========================================
  Files          895      897       +2     
  Lines        31452    31559     +107     
===========================================
+ Hits         29882    29989     +107     
  Misses        1570     1570              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stevenbal]

I note you removed some of the apimocks.

The problem was that because the endpoints just return what is in the files, the objectcontactmomenten can only belong to one of the Contactmomenten, meaning that the detailview for the second contactmoment raises assertionerrors

[pi-sigma]

Following the link of a question in the case detail page produces an unhandled AtributeError because of the missing mock (or did I fail to configure something?):

Traceback (most recent call last):
  File "/home/pi-sigma/.virtualenvs/oi-main/lib/python3.11/site-packages/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
               ^^^^^^^^^^^^^^^^^^^^^
  File "/home/pi-sigma/.virtualenvs/oi-main/lib/python3.11/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pi-sigma/.virtualenvs/oi-main/lib/python3.11/site-packages/cms/utils/decorators.py", line 20, in inner
    return func(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pi-sigma/.virtualenvs/oi-main/lib/python3.11/site-packages/django/views/generic/base.py", line 104, in view
    return self.dispatch(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pi-sigma/dev/maykin/open-inwoner/src/open_inwoner/accounts/views/contactmoments.py", line 57, in dispatch
    return super().dispatch(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pi-sigma/.virtualenvs/oi-main/lib/python3.11/site-packages/django/views/generic/base.py", line 143, in dispatch
    return handler(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pi-sigma/dev/maykin/open-inwoner/src/open_inwoner/accounts/views/contactmoments.py", line 252, in get
    kcms = contactmoment_client.retrieve_klantcontactmomenten_for_klant(klant)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pi-sigma/dev/maykin/open-inwoner/src/open_inwoner/openklant/clients.py", line 224, in retrieve_klantcontactmomenten_for_klant
    params={"klant": klant.url},
                     ^^^^^^^^^

Exception Type: AttributeError at /mijn-aanvragen/contactmoment/aaaaaaaa-aaaa-aaaa-aaaa-bbbbbbbbbbb2/
Exception Value: 'NoneType' object has no attribute 'url'

Judging from the tests I think it will work when data is present.

I stumbled over the API mocks myself and created an issue for it: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2196

We can discuss on Monday if we want to further modify/expand them so that they're more useful

[pi-sigma]

I don't know if the AttributeError is due to misconfiguration on my part or the missing mock.

A few remarks about the placement of KlantcontactMomenten in the admin the naming of classes/functions. Doesn't have to be changed, but double-check.

[stevenbal]

I don't know if the AttributeError is due to misconfiguration on my part or the missing mock.

do you have the Klanten API configured in your local Open Klant configuration?

[pi-sigma]

I do have the API configured but I receive a 401 Client Error for the call to our openklant-read test API. Strange as it worked before and now doesn't, but the problem seems to be on my end.