[#2058] Added status_text attribute to FeedItem, fixed issue in case_status item
#1063
Conversation
Bartvaderkin
requested review from
pi-sigma and
jiromaykin
and removed request for
pi-sigma
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1063 +/- ##
=========================================
Coverage 94.94% 94.95%
=========================================
Files 883 886 +3
Lines 31031 31191 +160
=========================================
+ Hits 29463 29616 +153
- Misses 1568 1575 +7 ☔ View full report in Codecov by Sentry. |
…' into feature/2058-actionable-userfeed
| <div class="userfeed-marker userfeed-marker--warning"> | ||
| {% icon icon="warning_amber" icon_position="after" extra_classes="icon--warning" outlined=True %} | ||
| <span class="userfeed__status_text">{{ item.status_text }}</span> | ||
| </div> | ||
| {% else %} | ||
| <div class="userfeed-marker userfeed-marker--info"> | ||
| {% icon icon="info" icon_position="after" extra_classes="icon--default" outlined=True %} | ||
| <span class="userfeed__status_text">{{ item.status_text }}</span> | ||
| </div> | ||
| {% endif %} |
There was a problem hiding this comment.
The status in the classnames should be dynamic, eg: userfeed-marker--{{ item.status_indicator }} or icon--{{ item.status_indicator }}.
So not an if/else switched on action_required, just use the value from the item.
So you have warning, info, error and success versions of the classes. The default is info. These are the values from open_inwoner.openzaak.constants.StatusIndicators
There was a problem hiding this comment.
This means I still needed to add conditions to retrieve the correct icons in my most recent commit,
as I don't seem to be able to do something like this here:
{% include "components/StatusIndicator/StatusIndicator.html" with status_indicator=item.status_indicator .....
There was a problem hiding this comment.
Feels weird that doesn't work.
jiromaykin
force-pushed
the
feature/2058-actionable-userfeed
branch
from
e02b67d
to
1d9b416
Compare
jiromaykin
force-pushed
the
feature/2058-actionable-userfeed
branch
from
9f34de9
to
8ec0761
Compare
Followup on #1058