Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2058] Added status indicator to case_status userfeed items #1058

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

Bartvaderkin
Copy link
Contributor

@Bartvaderkin Bartvaderkin commented Feb 27, 2024

Also added some counters to the admin.

Can be technically reviewed, but @jiromaykin will update the template with appropriate styling modifications

Comment on lines +22 to +26

<p class="p" style="color: rebeccapurple; font-size: 300%;">
{{ item.status_indicator }}
</p>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiromaykin item.status_indicator is one of open_inwoner.openzaak.constants.StatusIndicators

@Bartvaderkin Bartvaderkin force-pushed the feature/2058-actionable-userfeed branch from 7e684e8 to 2c5d122 Compare February 27, 2024 11:29
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 95.23810% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 94.94%. Comparing base (db9db6f) to head (7e684e8).

❗ Current head 7e684e8 differs from pull request most recent head 2c5d122. Consider uploading reports for the commit 2c5d122 to get more accurate results

Files Patch % Lines
src/open_inwoner/openzaak/admin.py 83.33% 2 Missing ⚠️
src/open_inwoner/openzaak/managers.py 94.44% 1 Missing ⚠️
src/open_inwoner/userfeed/adapter.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1058   +/-   ##
========================================
  Coverage    94.94%   94.94%           
========================================
  Files          883      883           
  Lines        30950    31031   +81     
========================================
+ Hits         29386    29463   +77     
- Misses        1564     1568    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bartvaderkin Bartvaderkin marked this pull request as ready for review February 27, 2024 12:30
@@ -288,6 +290,8 @@ class ZaakTypeConfigAdmin(admin.ModelAdmin):
"contact_subject_code",
"document_upload_enabled",
"num_infotypes",
"num_statustypes",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was probably already an issue before this change, but this list display is getting a bit out of hand 😬

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I noticed and decided I didn't want to deal with it at the time 😉

@alextreme alextreme merged commit a410dd2 into develop Feb 29, 2024
15 checks passed
@alextreme alextreme deleted the feature/2058-actionable-userfeed branch February 29, 2024 12:58
@Bartvaderkin
Copy link
Contributor Author

@alextreme slightly too fast @jiromaykin was working on the styling. We'll send fixes in a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants