🗑️ [#2062] Remove card templatetags #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1010 +/- ##
===========================================
- Coverage 94.74% 94.74% -0.01%
===========================================
Files 872 872
Lines 30571 30544 -27
===========================================
- Hits 28965 28939 -26
+ Misses 1606 1605 -1 ☔ View full report in Codecov by Sentry. |
stevenbal
force-pushed
the
cleanup/2062-remove-card-templatetags
branch
3 times, most recently
from
6af9edd
to
a7ebcbf
Compare
stevenbal
commented
Feb 8, 2024
stevenbal
force-pushed
the
cleanup/2062-remove-card-templatetags
branch
from
a7ebcbf
to
57314b1
Compare
stevenbal
force-pushed
the
cleanup/2062-remove-card-templatetags
branch
from
7a7a817
to
997c18c
Compare
pi-sigma
approved these changes
Feb 8, 2024
jiromaykin
approved these changes
Feb 12, 2024
| @@ -55,113 +26,3 @@ def render_card(parser, token): | |||
| nodelist = parser.parse(("endrender_card",)) | |||
| parser.delete_first_token() | |||
| return ContentsNode(nodelist, "components/Card/RenderCard.html", **context_kwargs) | |||
There was a problem hiding this comment.
Very pleasant clean-up :-)
| @@ -0,0 +1,16 @@ | |||
| {% load link_tags string_tags %} | |||
| <div class="card card__body"> | |||
| {% if location_name %} | |||
There was a problem hiding this comment.
I see this card is in the 'old' style and contains a link inside, (as opposed to all the other cards that are entirely clickable with a surrounding anchor instead) but then again: we'll indeed need to keep the phone/mail as clickable items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2062