[#2055] Add option to use different email tamplate for status notifications that require action

[pi-sigma]

Taiga #2055

• Added the option to use a special template for status change notifications that indicate that action is required
• Took the opportunity to refactor some of the code in openzaak/notifications.py

TODO:

• the case_status_notification_action_required template needs to be implemented (cf. this PR)

[codecov-commenter]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c5784fd) 94.75% compared to head (32ba6a1) 94.76%.
Report is 5 commits behind head on develop.

Files	Patch %	Lines
src/open_inwoner/openzaak/notifications.py	93.33%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1001      +/-   ##
===========================================
+ Coverage    94.75%   94.76%   +0.01%     
===========================================
  Files          869      872       +3     
  Lines        30288    30559     +271     
===========================================
+ Hits         28698    28958     +260     
- Misses        1590     1601      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pi-sigma]

@stevenbal I'm waiting for Jiro's PR for the action_required template, but the rest should work as is.

[stevenbal]

Looks good, just a few remarks/questions. Good that you split up handle_status_notification into several functions, because it was getting quite complicated logic-wise

[stevenbal]

I would probably make this Dutch, something like this maybe:

Suggested change

	"subject_default": "Action required",
	"subject_default": "Uw zaak is bijgewerkt op {{ site_name }} (actie vereist)",

In case there is a specific subject in the design that we're going to use, you can ignore this

[pi-sigma]

Design is still WIP, so I'm going to change this as suggested.

[stevenbal]

Does oz_config.skip_notification_statustype_informeren have to be checked here? Since it is being checked in check_zaaktype_config as well

[pi-sigma]

I think so, because oz_config.skip_notification_statustype_informeren is not checked on its own in either function. In check_status_type, it is part of a check that involves status_type.informeren, and in check_zaaktype_config it's part of a check that also involves ztc. So I don't think it is redundant in either case.