Skip to content

Commit 672f3a2

Browse files
committed
💄 [#1338] Improved banner syntax and adjusted top position
1 parent 1de1a80 commit 672f3a2

File tree

7 files changed

+7
-7
lines changed

7 files changed

+7
-7
lines changed

src/open_inwoner/accounts/templates/registration/login.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44

55
{% block header_image %}
6-
<aside aria-hidden="true">
6+
<aside class="banner" aria-hidden="true">
77
<img class="main-image" src="{{ hero_image_login }}" alt="Header afbeelding">
88
</aside>
99
{% endblock header_image %}

src/open_inwoner/scss/components/Container/Container.scss

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
.container {
2-
margin: var(--row-height) var(--spacing-large) var(--row-height)
2+
margin: var(--spacing-large) var(--spacing-large) var(--row-height)
33
var(--spacing-large);
44
min-height: calc(
55
100vh - var(--header-height) - calc(var(--row-height) * 3) - 400px

src/open_inwoner/scss/components/MainImage/MainImage.scss

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ $image-height: 261px;
1212
@media (min-width: 768px) {
1313
aspect-ratio: 64 / 13;
1414
position: relative;
15-
top: calc(-1 * var(--row-height));
15+
top: 0;
1616
}
1717

1818
&.main-image--start-after ~ .container {

src/open_inwoner/templates/pages/category/detail.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
{% block header_image %}
55
{% if object.image %}
6-
<aside aria-hidden="true">
6+
<aside class="banner" aria-hidden="true">
77
<img class="main-image main-image--start-after" src="{{ object.image.url }}" alt="{{ object.image.default_alt_text|default:'Header afbeelding' }}">
88
</aside>
99
{% endif %}

src/open_inwoner/templates/pages/home.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
{% load i18n button_tags card_tags map_tags questionnaire_tags grid_tags product_tags utils string_tags %}
33

44
{% block header_image %}
5-
<aside aria-hidden="true">
5+
<aside class="banner" aria-hidden="true">
66
<img class="main-image" src="{{ hero_image_login }}" alt="Header image">
77
</aside>
88
{% endblock header_image %}

src/open_inwoner/templates/pages/plans/list.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
{% block header_image %}
55
{% if plans_banner %}
6-
<aside aria-hidden="true">
6+
<aside class="banner" aria-hidden="true">
77
<img class="main-image main-image--start-after" src="{{ plans_banner }}" alt="{{ plans_banner.default_alt_text|default:'Header afbeelding' }}">
88
</aside>
99
{% endif %}

src/open_inwoner/templates/pages/product/detail.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
{% block header_image %}
55
{% if object.image %}
6-
<aside aria-hidden="true">
6+
<aside class="banner" aria-hidden="true">
77
<img class="main-image main-image--start-after" src="{{ object.image.url }}">
88
</aside>
99
{% endif %}

0 commit comments

Comments
 (0)