Merge pull request #399 from maykinmedia/issue/967-message-problems

[#967] Fixed inbox to handle zero messages or contacts, added tests

Author: alextreme

src/open_inwoner/accounts/tests/test_inbox_page.py

@@ -158,6 +158,23 @@ def test_reply_message(self):
         self.assertEqual(last_message.sender, self.contact1)
         self.assertEqual(last_message.receiver, self.user)
 
+    def test_no_messages(self):
+        Message.objects.all().delete()
+
+        response = self.app.get(self.url, auto_follow=True)
+        self.assertEqual(response.status_code, 200)
+        # no form
+        self.assertFalse(response.pyquery("form#message-form"))
+
+    def test_no_contacts(self):
+        self.contact1.delete()
+        self.contact2.delete()
+
+        response = self.app.get(self.url, auto_follow=True)
+        self.assertEqual(response.status_code, 200)
+        # no form
+        self.assertFalse(response.pyquery("form#message-form"))
+
 
 class BaseInboxPageSeleniumTests:
     options = None

src/open_inwoner/accounts/views/inbox.py

@@ -40,13 +40,18 @@ def get_context_data(self, **kwargs):
         messages = self.get_messages(other_user)
         status = self.get_status(messages)
 
+        if other_user:
+            conversation_url = reverse(
+                "accounts:inbox", kwargs={self.slug_field: other_user.uuid}
+            )
+        else:
+            conversation_url = ""
+
         context.update(
             {
                 "conversations": conversations,
                 "conversation_messages": messages,
-                "conversation_url": reverse(
-                    "accounts:inbox", kwargs={self.slug_field: other_user.uuid}
-                ),
+                "conversation_url": conversation_url,
                 "other_user": other_user,
                 "status": status,
             }