Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add setup_configuration command #368

Merged
merged 9 commits into from
Apr 23, 2024
Merged

add setup_configuration command #368

merged 9 commits into from
Apr 23, 2024

Conversation

annashamray
Copy link
Collaborator

@annashamray annashamray commented Mar 5, 2024 •
edited
Loading

issue - maykinmedia/django-setup-configuration#1 (Objects API part)

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.27047% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 95.22%. Comparing base (9cb3e4b) to head (9eb272d).

Files Patch % Lines
src/objects/config/demo.py 88.88% 3 Missing ⚠️
src/objects/config/objecttypes.py 88.00% 3 Missing ⚠️
src/objects/api/fields.py 85.71% 2 Missing ⚠️
src/objects/utils/__init__.py 85.71% 2 Missing ⚠️
src/objects/conf/base.py 92.85% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
+ Coverage   94.90%   95.22%   +0.32%     
==========================================
  Files         133      142       +9     
  Lines        4628     5029     +401     
==========================================
+ Hits         4392     4789     +397     
- Misses        236      240       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@annashamray annashamray marked this pull request as ready for review March 11, 2024 17:34
@annashamray annashamray mentioned this pull request Mar 12, 2024
Closed
@annashamray annashamray force-pushed the feature/setup-configuration branch 2 times, most recently from bdabca5 to f3c34da Compare April 22, 2024 15:13
@annashamray annashamray mentioned this pull request Apr 23, 2024
Closed
2 tasks
stevenbal
stevenbal approved these changes Apr 23, 2024
View reviewed changes
docker-compose.yml
- DEMO_CONFIG_ENABLE=yes
- DEMO_TOKEN=demo-random-string
- DEMO_PERSON=Demo
- [email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my information: is there a reason we have a regular docker-compose.yml and a docker-compose-quickstart.yml?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker-compose-quickstart.yml was added with the idea of giving quick demo. So the user can follow steps in README and very quickly have Objects API up and running. And it uses the published docker image, so you can just download this file without cloning the whole repo.

I don't know if it's still needed to be honest. You can ask Joeri, he was behind this quickstart thing

docs/installation/config_cli.rst
Comment on lines +115 to +118
With the full command invocation, everything is configured at once and immediately
tested.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have a readthedocs for setup-configuration yet, but maybe it would be nice to have a reference to that here at some point

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. For now setup_configuration lib has just README, I'll put a link for it here

@stevenbal
Copy link
Contributor

Looks good, just one question and a remark

@annashamray
➕ [maykinmedia/django-setup-configuration#1] add django_setup_configu…
fa398d3 
…ration
@annashamray
✨ [maykinmedia/django-setup-configuration#1] add configuration steps
b2e586e
@annashamray
✅ [maykinmedia/django-setup-configuration#1] test configuration steps
a4de147
@annashamray
🐳 [maykinmedia/django-setup-configuration#1] add setup_configuration …
5e3fadd 
…into docker
@annashamray
🐛 [maykinmedia/django-setup-configuration#1] fix selftest for the con…
c62a9b5 
…figurations step
@annashamray
📝 [maykinmedia/django-setup-configuration#1] document setup_configura…
da82abe 
…tion command and env vars
@annashamray
⬆️ replace git dep with pypi for django_setup_configuration
c5f3a1f
@annashamray
♻️ [maykinmedia/django-setup-configuration#1] replace get_or_create w…
0ee3a7d 
…ith update_or_create in config steps
@annashamray
📝 reference 'setup_configuration' repo in the documentation
22bb539
@annashamray annashamray merged commit 7b285b4 into master Apr 23, 2024
8 checks passed
@annashamray annashamray deleted the feature/setup-configuration branch April 23, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenbal stevenbal stevenbal approved these changes

@joeribekker joeribekker Awaiting requested review from joeribekker

@bart-maykin bart-maykin Awaiting requested review from bart-maykin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annashamray @codecov-commenter @stevenbal