Skip to content

Commit 61be24d

Browse files
committed
♻️ [maykinmedia/django-setup-configuration#1] replace get_or_create with update_or_create in config steps
1 parent 46202d3 commit 61be24d

File tree

2 files changed

+2
-13
lines changed

2 files changed

+2
-13
lines changed

src/objects/config/demo.py

+1-8
Original file line numberDiff line numberDiff line change
@@ -28,21 +28,14 @@ def is_configured(self) -> bool:
2828
return TokenAuth.objects.filter(token=settings.DEMO_TOKEN).exists()
2929

3030
def configure(self):
31-
token_auth, created = TokenAuth.objects.get_or_create(
31+
TokenAuth.objects.update_or_create(
3232
token=settings.DEMO_TOKEN,
3333
defaults={
3434
"contact_person": settings.DEMO_PERSON,
3535
"email": settings.DEMO_EMAIL,
3636
"is_superuser": True,
3737
},
3838
)
39-
if (
40-
token_auth.contact_person != settings.DEMO_PERSON
41-
or token_auth.email != settings.DEMO_EMAIL
42-
):
43-
token_auth.contact_person = settings.DEMO_PERSON
44-
token_auth.email = settings.DEMO_EMAIL
45-
token_auth.save(update_fields=["contact_person", "email"])
4639

4740
def test_configuration(self):
4841
endpoint = reverse("v2:object-list")

src/objects/config/objecttypes.py

+1-5
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def is_configured(self) -> bool:
2727
return Service.objects.filter(api_root=settings.OBJECTTYPES_API_ROOT).exists()
2828

2929
def configure(self) -> None:
30-
service, created = Service.objects.update_or_create(
30+
Service.objects.update_or_create(
3131
api_root=settings.OBJECTTYPES_API_ROOT,
3232
defaults={
3333
"label": "Objecttypes API",
@@ -38,10 +38,6 @@ def configure(self) -> None:
3838
"header_value": f"Token {settings.OBJECTS_OBJECTTYPES_TOKEN}",
3939
},
4040
)
41-
if not created:
42-
service.oas = settings.OBJECTTYPES_API_OAS
43-
service.header_value = f"Token {settings.OBJECTS_OBJECTTYPES_TOKEN}"
44-
service.save(update_fields=["oas", "header_value"])
4541

4642
def test_configuration(self) -> None:
4743
"""

0 commit comments

Comments
 (0)