🐛 [#62] Fix setup-config-usage ToS step links #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
swrichards
requested changes
Feb 10, 2025
| {% endif %} | ||
|
|
||
| {% for step in steps %} | ||
| - {% if show_steps %}`{{ step.title }} <#{{ step.anchor_id }}>`_{% else %} {{ step.title }} {% endif %} | ||
| - {% if show_steps %}`{{ step.title }} <#{{ step.module_path }}>`_{% else %} {{ step.title }} {% endif %} |
There was a problem hiding this comment.
I think anchor_id might not be used at all now? If so, it would be good to just remove it from the dataclass passed to the template to avoid confusion in future. We'll just use module_path as here.
This was referenced Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of ToS links not working: https://open-zaak--1894.org.readthedocs.build/en/1894/installation/config/openzaak_config_cli.html#ref_step_vng_api_common.contrib.setup_configuration.steps.ApplicatieConfigurationStep