Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max length 1000 is not sufficient #29

Closed
LaurensBurger opened this issue Oct 5, 2023 · 1 comment · Fixed by #30
Closed

Max length 1000 is not sufficient #29

LaurensBurger opened this issue Oct 5, 2023 · 1 comment · Fixed by #30
Assignees
@pi-sigma

Comments

@LaurensBurger
Copy link
Member

https://github.com/maykinmedia/django-log-outgoing-requests/blob/272d3e933e9c9ed8ad9e1ca12d44dbc2fd0d1175/log_outgoing_requests/models.py#L19C3-L24C6

DataError
value too long for type character varying(1000)

For urls with large tokens the max length of 1000 is not sufficient:

{
method: 'get', 
params: None, 
timeout: 10.0, 
url: 'https://keycloak.site.nl/realms/publiek/protocol/openid-connect/logout?id_token_hint=ey..
}
@sergei-maertens
Copy link
Member

-> let's make it a TextField instead

pi-sigma added a commit that referenced this issue Oct 6, 2023
@pi-sigma
[#29] change url field to textfield
b975aa3
@pi-sigma pi-sigma mentioned this issue Oct 6, 2023
Merged
sergei-maertens added a commit that referenced this issue Oct 6, 2023
@sergei-maertens
Merge pull request #30 from maykinmedia/fix/29-url-length
1d1b877 
[#29] change url field to textfield
@pi-sigma pi-sigma mentioned this issue Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pi-sigma pi-sigma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#29] change url field to textfield maykinmedia/django-log-outgoing-requests
3 participants
@sergei-maertens @pi-sigma @LaurensBurger