Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ReaderMode): consider using iframe instead of dialog #18

Open
maxpatiiuk opened this issue Feb 11, 2024 · 0 comments
Open

refactor(ReaderMode): consider using iframe instead of dialog #18

maxpatiiuk opened this issue Feb 11, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@maxpatiiuk
Copy link
Owner

Consider displaying the reader mode using iframe instead of dialog
While the dialog is easy to use, it does not provide sufficient isolation from styles, scroll jacking, keyboard intercept, CSS filters, and the rest, even inside the Shadow DOM

i.e https://chromewebstore.google.com/detail/dom-distiller-reading-mod/oiembdaoobijmdmeobkalaehgifealpl works that way

However there are also cons of doing that:

  • Iframe would work worse with other tools, extensions, and screen readers. It might work worse with printing too
    • i.e dom distiller extension has some people complaining that the extension doesn't play nicely with other extensions
@maxpatiiuk maxpatiiuk added the enhancement New feature or request label Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant