Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow a custom inserter function for Tree.Insert. #24

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Allow a custom inserter function for Tree.Insert. #24

merged 1 commit into from
Aug 10, 2021

Conversation

UmanShahzad
Copy link
Contributor

@UmanShahzad UmanShahzad commented Aug 6, 2021 •
edited
Loading

Fixes #22

In order to do this properly we needed to create some new types, because there are actually 2 different types of insertion functions - one is a generator, and the other is the actual inserter.

oschwald
oschwald approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@oschwald oschwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oschwald oschwald merged commit e63de52 into maxmind:main Aug 10, 2021
@UmanShahzad UmanShahzad deleted the custom-inserter branch August 11, 2021 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oschwald oschwald oschwald approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Tree to have default insert func
2 participants
@UmanShahzad @oschwald