Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update httpclient artifact #40

Closed
lewismc opened this issue Jun 5, 2015 · 5 comments
Closed

Update httpclient artifact #40

lewismc opened this issue Jun 5, 2015 · 5 comments

Comments

@lewismc
Copy link

lewismc commented Jun 5, 2015

Hi Folks,
There are newever versions of the Apache httpclient artifact which this library should consider updating to.
Clients consuming geoip2 have classloading issues due to geoip2 using an old httpclient version.
I'll see if I can get something together and submit a PR.

@oschwald
Copy link
Member

oschwald commented Jun 5, 2015

We currently use the Google HTTP Client Library, which is what is pulling in the old version of httpclient. We have considered moving to using Apache httpclient directly to help avoid issues like this, but the work for doing so isn't currently scheduled.

@lewismc
Copy link
Author

lewismc commented Jun 5, 2015

That's a real shame... I will see if I can maybe even submit a patch for transition to httpclient

@oschwald
Copy link
Member

oschwald commented Jun 5, 2015

I'm not sure if it will work, but have you tried excluding the old version of httpcient? For instance:

    <dependency>
        <groupId>com.maxmind.geoip2</groupId>
        <artifactId>geoip2</artifactId>
        <version>2.2.0</version>
        <exclusions>
          <exclusion>
            <groupId>org.apache.httpcomponents<</groupId>
            <artifactId>httpclient</artifactId>
          </exclusion>
        </exclusions> 
    </dependency>

@irmakozonay
Copy link

Excluding the old version worked for me.

@oschwald
Copy link
Member

This is fixed by 2.8.0-rc1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants