Skip to content

Commit 03e315c

Browse files
authored
fix: jfxname magic property fixed on windows Fixes quarkusio#526 (quarkusio#527)
Fixes quarkusio#526
1 parent 2949c73 commit 03e315c

File tree

2 files changed

+21
-0
lines changed

2 files changed

+21
-0
lines changed

src/main/java/dev/jbang/Detector.java

+2
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ public void detect(Properties properties, List<String> classiferWithLikes) {
2626
String os = properties.getProperty("os.detected.name");
2727
if (os.equals("osx")) {
2828
os = "mac";
29+
} else if (os.equals("windows")) {
30+
os = "win";
2931
}
3032
properties.setProperty("os.detected.jfxname", os);
3133
System.setProperty("os.detected.jfxname", os);

src/test/java/dev/jbang/DependencyResolverTest.java

+19
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,25 @@ void testdepIdWithPlaceHoldersToArtifact() {
9797
assertEquals("jar", artifact.getType().getExtension());
9898
}
9999

100+
@Test
101+
void testResolveJavaFXWithAether() {
102+
103+
dev.jbang.Detector detector = new dev.jbang.Detector();
104+
detector.detect(new Properties(), Collections.emptyList());
105+
106+
DependencyUtil dr = new DependencyUtil();
107+
108+
List<String> deps = Arrays.asList(
109+
PropertiesValueResolver.replaceProperties("org.openjfx:javafx-base:11.0.2:${os.detected.jfxname}"));
110+
111+
List<ArtifactInfo> artifacts = dr.resolveDependenciesViaAether(deps,
112+
Arrays.asList(toMavenRepo("jcenter")), false,
113+
true, true);
114+
115+
assertEquals(1, artifacts.size());
116+
117+
}
118+
100119
@Test
101120
void testResolveDependenciesWithAether() {
102121

0 commit comments

Comments
 (0)