New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minimist to latest #13

Closed

hkuchibhotla opened this issue Sep 2, 2020 · 5 comments

Contributor

hkuchibhotla commented Sep 2, 2020 •

edited

Loading

This repo uses minmist 0.0.7, which seems to have some security vulnerabilities.
Can we update to the latest 1.2.5

   "minimist": "1.2.5"

Tests Passed

The text was updated successfully, but these errors were encountered:

Collaborator

ungoldman commented Sep 2, 2020

fine by me, PR welcome

Contributor Author

hkuchibhotla commented Sep 3, 2020 •

edited

Loading

@ungoldman Thank you, can i get write access to commit/ open a PR?

Collaborator

ungoldman commented Sep 3, 2020 •

edited

Loading

@hkuchibhotla you can fork this repo and open a PR by following these instructions: https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork

Contributor Author

hkuchibhotla commented Sep 4, 2020

Thank you @ungoldman, here it is: #14

Collaborator

ungoldman commented Sep 10, 2020 •

edited

Loading

Thank you @hkuchibhotla! Resolved in #14, published in v1.0.4

ungoldman closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment