pkg-config file has CI paths

[battlesnake]

$ pkg-config --cflags mavsdk
-I/home/runner/work/MAVSDK/MAVSDK/install/include -I/home/runner/work/MAVSDK/MAVSDK/install/include/mavsdk -I/usr/include/x86_64-linux-gnu -I/usr/include/jsoncpp

The include paths in the current ubuntu 22.04 pkg-config file seem to reference CI user directories instead of the eventual installation directories.

[battlesnake]

(sanity check: I don't have a user called runner or a /home/runner directory)

[battlesnake]

$ cat /usr/lib/pkgconfig/mavsdk.pc
prefix=/home/runner/work/MAVSDK/MAVSDK/install
exec_prefix=/home/runner/work/MAVSDK/MAVSDK/install/bin
libdir=/home/runner/work/MAVSDK/MAVSDK/install/lib
includedir=/home/runner/work/MAVSDK/MAVSDK/install/include

...

[battlesnake]

Similar for Debain 12 ARM64: /work/build/linux-arm64/install

[JonasVautherin]

This is what's being used to generate it. If I remember correctly, those variables are defined with CMAKE_INSTALL_PREFIX and GNUInstallDirs.

My guess would be that it is all coming from CMAKE_INSTALL_PREFIX in the end. And it is set e.g. here in the CI.

I feel like the CI jobs for the CI should not override CMAKE_INSTALL_PREFIX and install on the system instead.

Would you be able to test that?

[battlesnake]

Sure I can test stuff - I'm installing MAVSDK as part of a container build so I can test changes pretty easily by applying them and commenting out my current workarounds. I'll try to fit it in sometime tomorrow.

[julianoes]

Those paths work for the .deb packages, so I'm confused why they don't for the pkg-config. I guess we always just use CMake's find_package and not pkg-config.