-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Winch and Gripper plugins #545
Conversation
09b880c
to
ecfc5a8
Compare
I cleaned up the commits and rebased on top of the main branch. The most recent MAVSDK Server version 1.14.12 was released just two weeks ago, but the Proto submodule used in it was not up to date. Currently there is no MAVSDK Server release that contains the gripper and winch additions from Proto. TODO: Wait for new mavsdk server release and then update |
So this is meant to come with MAVSDK v2, right? |
Yes, it will be part of v2. Sorry for the wait, MAVSDK v2 is just what I do in my spare time. |
Sure, I was just wondering if @potaito was expecting it in 1.4 or not 😅 |
I guess this could now go in, now that we have 2.0. |
Signed-off-by: Julian Oes <[email protected]>
Great, thank you @julianoes :) |
Thank you 😄 |
Related PRs
Description
Adds the winch and gripper plugins also to MAVSDK-Python.
The example scripts are a bit tricky, since there is currently no simulation counterpart against which they can be used. They work in the sense that they send the corresponding commands, but MAVSDK will not receive an ACK if there is no winch or gripper component connected to MAVSDK. I don't know how we want to handle this for example scripts.
TODO
After updating the proto submodule and regenerating the python part, I got quite a lot of changes across the board and I'm not sure what needs to be committed:
I guess all changes need to be committed?
Please don't merge before I squashed the commits :)