Skip to content

Commit f063719

Browse files
authored
MAINT Use Chrome 89 in tests (pyodide#1462)
1 parent 57db723 commit f063719

File tree

6 files changed

+10
-10
lines changed

6 files changed

+10
-10
lines changed

.circleci/config.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ version: 2
33
defaults: &defaults
44
working_directory: ~/repo
55
docker:
6-
- image: iodide/pyodide-env:12
6+
- image: pyodide/pyodide-env:13
77
environment:
88
- EMSDK_NUM_CORES: 4
99
EMCC_CORES: 4
@@ -161,7 +161,7 @@ jobs:
161161
- run:
162162
name: test
163163
command: |
164-
tools/pytest_wrapper.py src packages/micropip/ -v -k chrome -n 3
164+
tools/pytest_wrapper.py src packages/micropip/ -v -k chrome
165165
166166
test-packages-firefox:
167167
<<: *defaults

.pre-commit-config.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ repos:
1818
# only check for unused imports, as the rest is done by black
1919
args: [--select=F401]
2020
- repo: https://github.com/pre-commit/mirrors-mypy
21-
rev: v0.782
21+
rev: v0.812
2222
hooks:
2323
- id: mypy
2424
args:

Dockerfile

+3-3
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ RUN apt-get update \
66
bzip2 ccache clang-format-6.0 cmake f2c g++ gfortran git make \
77
patch pkg-config swig unzip wget xz-utils \
88
# testing packages: libgconf-2-4 is necessary for running chromium
9-
libgconf-2-4 chromium \
9+
libgconf-2-4 "chromium=89.*" \
1010
&& rm -rf /var/lib/apt/lists/*
1111

1212
RUN pip3 --no-cache-dir install \
@@ -15,7 +15,7 @@ RUN pip3 --no-cache-dir install \
1515
distlib \
1616
flake8 \
1717
hypothesis \
18-
mypy \
18+
"mypy==0.812" \
1919
pytest \
2020
pytest-cov \
2121
pytest-httpserver \
@@ -31,7 +31,7 @@ RUN wget -qO- https://ftp.mozilla.org/pub/firefox/releases/70.0.1/linux-x86_64/e
3131
&& wget -qO- https://github.com/mozilla/geckodriver/releases/download/v0.26.0/geckodriver-v0.26.0-linux64.tar.gz | tar zxC /usr/local/bin/
3232

3333
# Get recent version of chromedriver
34-
RUN wget --quiet https://chromedriver.storage.googleapis.com/2.41/chromedriver_linux64.zip \
34+
RUN wget --quiet https://chromedriver.storage.googleapis.com/89.0.4389.23/chromedriver_linux64.zip \
3535
&& unzip chromedriver_linux64.zip \
3636
&& mv $PWD/chromedriver /usr/local/bin \
3737
&& rm -f chromedriver_linux64.zip

Dockerfile-prebuilt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
ARG VERSION
22

3-
FROM iodide/pyodide-env:${VERSION}
3+
FROM pyodide/pyodide-env:${VERSION}
44

55
USER root
66

run_docker

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ function error() {
2929
}
3030

3131

32-
PYODIDE_IMAGE_TAG="12"
32+
PYODIDE_IMAGE_TAG="13"
3333
PYODIDE_PREBUILT_IMAGE_TAG="0.17.0a2"
34-
DEFAULT_PYODIDE_DOCKER_IMAGE="iodide/pyodide-env:${PYODIDE_IMAGE_TAG}"
34+
DEFAULT_PYODIDE_DOCKER_IMAGE="pyodide/pyodide-env:${PYODIDE_IMAGE_TAG}"
3535
DEFAULT_PYODIDE_SYSTEM_PORT="8000"
3636
DOCKER_COMMAND="/bin/bash"
3737

src/tests/python_tests.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ test__xxsubinterpreters
4545
test_abc
4646
test_abstract_numbers
4747
test_aifc audioop
48-
test_argparse
48+
test_argparse crash-chrome
4949
test_array
5050
test_asdl_parser
5151
test_ast

0 commit comments

Comments
 (0)