Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a new release #29

Closed
AlexWayfer opened this issue Dec 13, 2020 · 6 comments
Closed

Make a new release #29

AlexWayfer opened this issue Dec 13, 2020 · 6 comments
Assignees

Comments

@AlexWayfer
Copy link
Collaborator

There were many changes, including client headers and authentication, so let's make a new release (0.5.0, I guess).

@mauricew
Copy link
Owner

I'll be looking to get #6 done before the release happens.

@gareth
Copy link

gareth commented May 5, 2023

I'll be looking to get #6 done before the release happens.

Is this still true? It's now >4 years since the latest "official" release

@mauricew
Copy link
Owner

mauricew commented May 5, 2023

I apologize for the lack of communication, I might as well give a little postmortem here.

  1. Just a few weeks after this, life got in the way and that unfortunately took away the time that I had dedicated to work on this repo, which put all sorts of things out of wack.
  2. It was a big mistake to return strongly typed classes with the way the API was changing as frequently as it was. I now believe there should've been an option to return hashes from the start and just have the option to use it as an enhanced HTTP client (still keeping the convenience methods)
  3. Above all I'm just not interested in ruby anymore.

@AlexWayfer I'll add you as a gem maintainer if you can provide me your information to do so. Feel free to merge/release with whatever changes you have pending. Also that PR above just needs some extra test cases to pass (and even might be outdated at this point)

@AlexWayfer
Copy link
Collaborator Author

@AlexWayfer I'll add you as a gem maintainer if you can provide me your information to do so.

Em… of course, but my info is public everywhere. AlexWayfer is nickname on any platform and [email protected] is my email address.

I'd like to try to continue maintain this gem.

2. It was a big mistake to return strongly typed classes with the way the API was changing as frequently as it was. I now believe there should've been an option to return hashes from the start and just have the option to use it as an enhanced HTTP client (still keeping the convenience methods)

I can understand this. And I have a little more experience now after working with telegram-bot-ruby gem: there is Client#call method, which returns raw Hash, and method_missing which checks for existing (gem-registered) methods and types.


I wish you luck with your life, even without Ruby. Thank you for your work. I'd like to have access to push this gem to RubyGems.org

@AlexWayfer
Copy link
Collaborator Author

NEWS: I've been added as the gem maintainer (thanks to @mauricew)!

I've merged open PRs meanwhile.

So, the new release is near.

I think I'll make it in the current state, without fresh end-points from open issues.

If you need for them — write there, or PRs are welcome.

@AlexWayfer
Copy link
Collaborator Author

AlexWayfer commented Aug 17, 2023

It has been done. Meet the new 1.0 version.

#6 and #30 have been completed. #39 has not.

There are always new end-points for us to implement. Asking and pull requests are welcome.

I have in plans some management with data classes, like a base class, etc. But I left it after v1.0. It works for now, and I'm kind of tired now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants