Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NPM packaging] AADev I have abstracted creating a MemoryVectorStore #43

Closed
SEBRATHEZEBRA opened this issue Jul 31, 2023 · 0 comments · Fixed by #47
Closed

[NPM packaging] AADev I have abstracted creating a MemoryVectorStore #43

SEBRATHEZEBRA opened this issue Jul 31, 2023 · 0 comments · Fixed by #47
Assignees
@SEBRATHEZEBRA
Milestone
v1 - npm package

Comments

@SEBRATHEZEBRA
Copy link
Contributor

Tech Steps:

  • In src/common/model create a file called createMemoryStore.ts
  • Create a function called createMemoryStore which takes a single argument, initialFiles and returns a VectorStore
  • Write test to make sure it works as expected
@SEBRATHEZEBRA SEBRATHEZEBRA self-assigned this Jul 31, 2023
@SEBRATHEZEBRA SEBRATHEZEBRA converted this from a draft issue Jul 31, 2023
@SEBRATHEZEBRA SEBRATHEZEBRA moved this from Backlog to In Progress in Code Review GPT Roadmap Jul 31, 2023
@SEBRATHEZEBRA SEBRATHEZEBRA linked a pull request Jul 31, 2023 that will close this issue
refactor: abstracting the creation of a vector store #47
Merged
@SEBRATHEZEBRA SEBRATHEZEBRA moved this from In Progress to To Validate in Code Review GPT Roadmap Jul 31, 2023
@mattzcarey mattzcarey added this to the v1 - npm package milestone Jul 31, 2023
@mattzcarey mattzcarey changed the title [Refactor] AADev I have abstracted creating a MemoryVectorStore [NPM packaging] AADev I have abstracted creating a MemoryVectorStore Aug 1, 2023
@github-project-automation github-project-automation bot moved this from To Validate to Done in Code Review GPT Roadmap Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SEBRATHEZEBRA SEBRATHEZEBRA

Labels
None yet
Projects
None yet
Milestone
v1 - npm package
Development

Successfully merging a pull request may close this issue.

refactor: abstracting the creation of a vector store mattzcarey/code-review-gpt
2 participants
@SEBRATHEZEBRA @mattzcarey