Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NPM Packaging] AAReviewLambda I do not contain any git commands #42

Closed
gowoons opened this issue Jul 31, 2023 · 0 comments · Fixed by #46
Closed

[NPM Packaging] AAReviewLambda I do not contain any git commands #42

gowoons opened this issue Jul 31, 2023 · 0 comments · Fixed by #46
Assignees

Comments

@gowoons
Copy link
Contributor

gowoons commented Jul 31, 2023

Tech steps

  • Create a git folder in src/common
  • Create functions for git commands (now in src/review/prompt/gitCommand.ts)
  • Create a function that uses the github env variables and returns a list of objects of type {fileName:string, fileContent:string, changedLines: string}
  • (Write tests for these functions ?)
  • In global index.ts, in case "review", call the git function first, and pass in the list of objects in the review function
@gowoons gowoons converted this from a draft issue Jul 31, 2023
@mattzcarey mattzcarey moved this from Backlog to Daily goals in Code Review GPT Roadmap Jul 31, 2023
@gowoons gowoons moved this from Daily goals to In Progress in Code Review GPT Roadmap Jul 31, 2023
@mattzcarey mattzcarey added this to the v1 - npm package milestone Jul 31, 2023
@gowoons gowoons moved this from In Progress to To Validate in Code Review GPT Roadmap Aug 1, 2023
@github-project-automation github-project-automation bot moved this from To Validate to Done in Code Review GPT Roadmap Aug 1, 2023
@mattzcarey mattzcarey changed the title [Refactor] AAReviewLambda I do not contain any git commands [NPM Packaging] AAReviewLambda I do not contain any git commands Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants