Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Update Api Key request is broken. #229

Closed
lizacullis opened this issue Aug 31, 2023 · 2 comments · Fixed by #239
Closed

[Bug] Update Api Key request is broken. #229

lizacullis opened this issue Aug 31, 2023 · 2 comments · Fixed by #239
Assignees
@SEBRATHEZEBRA

Comments

@lizacullis
Copy link
Contributor

lizacullis commented Aug 31, 2023 •
edited by SEBRATHEZEBRA
Loading

When updating the session User type, we only updated this for getUser, not UpdateUser in the profile page.
The getSession method doesn't return a session with the token in it, could be related.
@lizacullis lizacullis converted this from a draft issue Aug 31, 2023
@SEBRATHEZEBRA SEBRATHEZEBRA moved this from Sprint Backlog to Daily goals in Code Review GPT Roadmap Aug 31, 2023
@SEBRATHEZEBRA SEBRATHEZEBRA moved this from Daily goals to Sprint Backlog in Code Review GPT Roadmap Aug 31, 2023
@SEBRATHEZEBRA SEBRATHEZEBRA moved this from Sprint Backlog to Daily goals in Code Review GPT Roadmap Sep 1, 2023
@SEBRATHEZEBRA SEBRATHEZEBRA moved this from Daily goals to In Progress in Code Review GPT Roadmap Sep 1, 2023
@SEBRATHEZEBRA
Copy link
Contributor

Image

@SEBRATHEZEBRA SEBRATHEZEBRA linked a pull request Sep 4, 2023 that will close this issue
fix: update api key now uses userId #239
Merged
@lizacullis lizacullis moved this from In Progress to Code Review in Code Review GPT Roadmap Sep 4, 2023
@SEBRATHEZEBRA SEBRATHEZEBRA moved this from Code Review to Functional Review in Code Review GPT Roadmap Sep 4, 2023
@lizacullis lizacullis moved this from Functional Review to To Validate in Code Review GPT Roadmap Sep 5, 2023
@lizacullis lizacullis moved this from To Validate to Functional Review in Code Review GPT Roadmap Sep 5, 2023
@lizacullis
Copy link
Contributor Author

@SEBRATHEZEBRA Can we have some validation here?
maybe - screenshot of api key in ddb before and after updating the key.

@mattzcarey mattzcarey moved this from Functional Review to To Validate in Code Review GPT Roadmap Sep 7, 2023
@aiden-walton aiden-walton moved this from To Validate to Done in Code Review GPT Roadmap Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SEBRATHEZEBRA SEBRATHEZEBRA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update api key now uses userId mattzcarey/code-review-gpt
2 participants
@SEBRATHEZEBRA @lizacullis