Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] AAUser, I don't have a failure when there are only lines being removed in a file #175

Closed
gowoons opened this issue Aug 14, 2023 · 1 comment · Fixed by #174
Closed
Assignees

Comments

@gowoons
Copy link
Contributor

gowoons commented Aug 14, 2023

When using code review with a file that only has lines being removed, this is what happens:

Image

This is because when constructing the prompt, we compare the actual file and the changes to get the indexes of the changes. However since the lines have been removed, they are not in the actual file anymore. They are thus not added to the prompt.

Since bug could be more: AAUser, I include removed lines in the prompt

@gowoons gowoons converted this from a draft issue Aug 14, 2023
@gowoons gowoons moved this from Backlog to In Progress in Code Review GPT Roadmap Aug 14, 2023
@gowoons gowoons self-assigned this Aug 14, 2023
@gowoons gowoons moved this from In Progress to BR Done in Code Review GPT Roadmap Aug 14, 2023
@gowoons gowoons moved this from BR Done to In Progress in Code Review GPT Roadmap Aug 14, 2023
@gowoons gowoons linked a pull request Aug 14, 2023 that will close this issue
@gowoons gowoons moved this from In Progress to Functional Review in Code Review GPT Roadmap Aug 14, 2023
@mattzcarey
Copy link
Owner

Followup ticket created to include the removed lines in review. Pushing this one as it fixes the failiure.

@mattzcarey mattzcarey moved this from Functional Review to To Validate in Code Review GPT Roadmap Aug 17, 2023
@mattzcarey mattzcarey moved this from To Validate to Done in Code Review GPT Roadmap Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants