fix bug with test properties creation and lookup not accounting for new parser attribute.

Author: mattpolzin

Sources/App/Controllers/APITestController.swift

@@ -223,8 +223,8 @@ extension APITestController {
             .filter(\.$id == testPropertiesId.rawValue)
             .with(\.$openAPISource)
             .first()
-            .optionalMap { ($0, $0.$openAPISource.value!) }
             .unwrap(or: Abort(.badRequest, reason: "Given API test properties could not be found."))
+            .map { ($0, $0.$openAPISource.value!) }
     }
 
     /// Attempt to find or create default test properties.
@@ -252,6 +252,7 @@ extension APITestController {
                     .query(on: db)
                     .filter(\.$openAPISource.$id == sourceId)
                     .filter(\.$apiHostOverride == nil)
+                    .filter(\.$parser == .stable)
                     .first(orCreate: DB.APITestProperties(openAPISourceId: sourceId, apiHostOverride: nil, parser: .stable))
                     .map { ($0, source) }
         }
@@ -385,7 +386,7 @@ extension APITestController {
             rootPath.map(\.openAPIPathComponent),
             use: self.create
         )
-            .tags("Testing")
+            .tags("Test Creation")
             .summary("Run tests")
             .description("""
 Running tests is an asynchronous operation. This route will return immediately if it was able to queue up a new test run.
@@ -399,15 +400,15 @@ You can monitor the status of your test run with the `GET` `/api_test/{id}` endp
             rootPath.map(\.openAPIPathComponent),
             use: self.index
         )
-            .tags("Testing")
+            .tags("Test Status", "Test Results")
             .summary("Retrieve all test results")
 
         app.on(
             .GET,
             rootPath.map(\.openAPIPathComponent) + [":id".description(idDescription)],
             use: self.show
         )
-            .tags("Testing")
+            .tags("Test Status", "Test Results")
             .summary("Retrieve a single test result")
 
         // MARK: File Retrieval

Sources/App/Controllers/APITestMessageController.swift

@@ -79,5 +79,7 @@ extension APITestMessageController {
             rootPath.map(\.openAPIPathComponent) + [":id".description("Id of the API Test Message.")],
             use: Self.show
         )
+        .tags("Test Results")
+        .summary("Retrieve a single test message")
     }
 }

Sources/App/Controllers/APITestPropertiesController.swift

@@ -92,6 +92,7 @@ extension APITestPropertiesController {
             DB.APITestProperties.query(on: req.db)
                 .filter(\.$openAPISource.$id == properties.$openAPISource.id)
                 .filter(\.$apiHostOverride == properties.apiHostOverride)
+                .filter(\.$parser == properties.parser)
                 .first(orCreate: properties)
         }
 

Sources/App/Controllers/OpenAPISourceController.swift

@@ -32,6 +32,7 @@ extension OpenAPISourceController {
             .flatMap(req.response.success.encode)
     }
 
+    /// Show an `OpenAPISource`.
     func show(_ req: TypedRequest<ShowContext>) throws -> EventLoopFuture<Response> {
         guard let id = req.parameters.get("id", as: UUID.self) else {
             return req.response.badRequest

Sources/App/Models/DB/APITestProperties+DB.swift

@@ -49,6 +49,7 @@ extension DB {
             self.id = UUID()
             self.createdAt = Date()
             self.$apiHostOverride.wrappedValue = apiModel.apiHostOverride
+            self.$parser.wrappedValue = apiModel.parser
             self.$openAPISource.id = openAPISourceId
         }