Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for python < 3.7 #63

Open
dvzrv opened this issue Nov 13, 2022 · 4 comments
Open

Drop support for python < 3.7 #63

dvzrv opened this issue Nov 13, 2022 · 4 comments

Comments

@dvzrv
Copy link

dvzrv commented Nov 13, 2022

Hi! I package this project for Arch Linux.

I would like to ask, whehter it would be possible to drop support for Python versions that are no longer supported by upstream.
Currently that's anything below 3.7: https://www.python.org/downloads/

Personally, I do not believe it is worth maintaining support for such old versions, as it introduces a lot of workarounds for maintaining compatibility.
As a plus: Issues like #54 will be much easier to solve.

@dvzrv
Copy link
Author

dvzrv commented Jan 5, 2023

@vstoykov @matthewwithanm ping

@vstoykov
Copy link
Collaborator

hey @dvzrv in #69 python versions for which we are testing is changed. It is still Python 3.6+ for compatibility reasons. The Python 2 and Python3.5 are removed from the classifiers, but the changes will not make the code stop working there. Simply we no longer test against these versions and in future commits braking changes can be safely introduced.

I know that at this moment even Python 3.7 is out of official support, but still the code is not using some fancy new features and is compatible.

Is this making any problems in packaging the app for Arch Linux even after #54 is fixed?

@dvzrv
Copy link
Author

dvzrv commented Sep 27, 2023

We will be able to drop mock from the test suite for this package finally!
We only support latest stable Python on Arch Linux, FWIW. Hence a release also targeting the current versions would be more than appreciated.

@vstoykov
Copy link
Collaborator

There is new release on PyPi with official support for till 3.11. I tested it with 3.12 locally but because it's still pre-release I did not added it to the test matrix in the CI. The new version also now has fixes to work with Pillow 10. In the test matrix now different versions of Pillow will also be tested because Pillow is now more active from changing the API than back in the days.

Also I did not explicitly dropped support for older versions of Python but new contributions can eventually break something because we are not testing older versions (<3.6).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants