Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We can omit these as they are default values. #205

Open
jfrerich opened this issue Mar 11, 2020 · 0 comments · May be fixed by #841
Open

We can omit these as they are default values. #205

jfrerich opened this issue Mar 11, 2020 · 0 comments · May be fixed by #841
Assignees
@Kshitij-Katiyar
Labels
Difficulty/1:Easy Easy ticket Hacktoberfest Help Wanted Community help wanted Tech/ReactJS Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers
Milestone
v2.4.0

Comments

@jfrerich
Copy link
Contributor

jfrerich commented Mar 11, 2020 •
edited
Loading

NOTE: This PR must be merged before code will appear in master. If it is merged, feel free to take!

We need to remove the input props that are set to the default values.

This line of code can be removed, as it is has a default value of false in the child tag.

Originally posted by @marianunez in #123
@jfrerich jfrerich added Difficulty/1:Easy Easy ticket Help Wanted Community help wanted Tech/ReactJS Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers labels Mar 11, 2020
@jfrerich jfrerich mentioned this issue Mar 11, 2020
Merged
@Kshitij-Katiyar Kshitij-Katiyar added this to the v2.4.0 milestone Sep 24, 2024
@Kshitij-Katiyar Kshitij-Katiyar linked a pull request Oct 28, 2024 that will close this issue
Open
@Kshitij-Katiyar Kshitij-Katiyar self-assigned this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kshitij-Katiyar Kshitij-Katiyar

Labels
Difficulty/1:Easy Easy ticket Hacktoberfest Help Wanted Community help wanted Tech/ReactJS Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
Milestone
v2.4.0
4 participants
@jespino @cpanato @jfrerich @Kshitij-Katiyar