Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop-over displays too low on on first attempt if there is not enough vertical space below the post #815

Open
wiggin77 opened this issue Aug 27, 2024 · 1 comment
Labels
Needs Mattermost Changes Requires changes to the Mattermost Plugin tookit

Comments

@wiggin77
Copy link
Member

There is an issue where the GitHub pop-over shows too low and is unreadable if the post is too low in the thread and there is not enough vertical space to show it.

It seems on the 1st attempt, the pop-over will always display below the post. On the 2nd attempt it will correctly display upward as it does not fit below. This should always happen.

First pop-over attempt:
jira_1

Second pop-over attempt:
jira_2

Note: I (@DHaussermann ) am unsure if this can be fixed in GitHub or if it's a webapp issue.

Steps:

See https://mattermost.atlassian.net/browse/MM-37643

@raghavaggarwal2308
Copy link
Contributor

@wiggin77 I don't think this can be fixed in the Github plugin as we are just registering a tooltip component in the plugin and the rest is handled by the MM webapp.

@raghavaggarwal2308 raghavaggarwal2308 added the Needs Mattermost Changes Requires changes to the Mattermost Plugin tookit label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Mattermost Changes Requires changes to the Mattermost Plugin tookit
Projects
Development

No branches or pull requests

2 participants