Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-809]: Fixed the issue of getting errors when using github api with revoked/invalid token #832

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[MM-809]: Fixed the issue of getting errors when using github api with revoked/invalid token #832

wants to merge 1 commit into from

Conversation

Kshitij-Katiyar
Copy link
Contributor

@Kshitij-Katiyar Kshitij-Katiyar commented Sep 26, 2024 •
edited
Loading

Summary

  • Fixed the issue of getting errors when using GitHub API with revoked/invalid tokens.
  • Created a wrapper function and used it on all the githubClient calls, in case of invalid token error, disconnected the user and DMed him to reconnect

Issue Link

Fixes #809

Testing steps

  • Connect your mattermost to Github plugin
  • Revoke the user access token on the Github Oauth app as shown in the screenshot
    Screenshot from 2024-09-27 13-30-52
  • Perform any action which involves API call using the Github client like LHS refresh, LHS button click

@raghavaggarwal2308 raghavaggarwal2308 added this to the v2.4.0 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raghavaggarwal2308 raghavaggarwal2308 Awaiting requested review from raghavaggarwal2308

@wiggin77 wiggin77 Awaiting requested review from wiggin77 wiggin77 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.

GitHub plugin issues on community after switching to SSO
2 participants
@Kshitij-Katiyar @raghavaggarwal2308