fix!: remove data hash argument from ItaxCode.valid? and ItaxCode::Validator#valid? #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29
This PR introduces a breaking change, so a bump to the next major is necessary.
The
.valid?method checks a pre-computed tax code against another one encoded from an user-provided hash of data. This check isn't reliable as it only checks the exact equality between the pre-computed tax code and the newly encoded one, returning false negatives for different but still valid tax codes (including omocodes).This PR simplifies the validity checks by dropping the data hash argument and validating just the provided tax code leveraging the decoder capabilities.