You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not really a bug but it seems like the "all" and "partial" options do the same thing for smartCopy. I looked through the source code and couldn't find any differences in behavior. I assume partial was intended to create an expanded selection if the selection text is a substring that contains the ellipsis? If you don't plan to implement that feature maybe it would be less confusing for that option to be deprecated (but still work until a major release).
I re-read the code and realized that the trigger for each option is different (i.e. partial works even if the selection is an inexact match), but in each case the copied data becomes the full text input, which seems wrong for substring selections.
The text was updated successfully, but these errors were encountered:
Sorry I reread the code and realized that partial actually is different, although I think its behavior may be incorrect since it doesn't actually select the substring the user chose.
I think it could be done more precisely like this:
Create another piece of state called excludedSubstring which is saved at the same time as truncatedText and contains exactly what it sounds like
When smartCopy is "partial" and a copy is made, you can produce the expanded substring with:
Not really a bug but it seems like the "all" and "partial" options do the same thing for smartCopy. I looked through the source code and couldn't find any differences in behavior. I assume partial was intended to create an expanded selection if the selection text is a substring that contains the ellipsis? If you don't plan to implement that feature maybe it would be less confusing for that option to be deprecated (but still work until a major release).I re-read the code and realized that the trigger for each option is different (i.e. partial works even if the selection is an inexact match), but in each case the copied data becomes the full text input, which seems wrong for substring selections.
The text was updated successfully, but these errors were encountered: