Skip to content

Commit 74485cf

Browse files
hnaztorvalds
authored andcommitted
mm: migrate: consolidate mem_cgroup_migrate() calls
Rather than scattering mem_cgroup_migrate() calls all over the place, have a single call from a safe place where every migration operation eventually ends up in - migrate_page_copy(). Signed-off-by: Johannes Weiner <[email protected]> Suggested-by: Hugh Dickins <[email protected]> Acked-by: Vladimir Davydov <[email protected]> Acked-by: Michal Hocko <[email protected]> Cc: Mateusz Guzik <[email protected]> Cc: Sergey Senozhatsky <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 7cf91a9 commit 74485cf

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

mm/migrate.c

+2-7
Original file line numberDiff line numberDiff line change
@@ -331,8 +331,6 @@ int migrate_page_move_mapping(struct address_space *mapping,
331331
if (PageSwapBacked(page))
332332
SetPageSwapBacked(newpage);
333333

334-
mem_cgroup_migrate(page, newpage);
335-
336334
return MIGRATEPAGE_SUCCESS;
337335
}
338336

@@ -428,8 +426,6 @@ int migrate_page_move_mapping(struct address_space *mapping,
428426
}
429427
local_irq_enable();
430428

431-
mem_cgroup_migrate(page, newpage);
432-
433429
return MIGRATEPAGE_SUCCESS;
434430
}
435431

@@ -471,8 +467,6 @@ int migrate_huge_page_move_mapping(struct address_space *mapping,
471467

472468
spin_unlock_irq(&mapping->tree_lock);
473469

474-
mem_cgroup_migrate(page, newpage);
475-
476470
return MIGRATEPAGE_SUCCESS;
477471
}
478472

@@ -586,6 +580,8 @@ void migrate_page_copy(struct page *newpage, struct page *page)
586580
end_page_writeback(newpage);
587581

588582
copy_page_owner(page, newpage);
583+
584+
mem_cgroup_migrate(page, newpage);
589585
}
590586

591587
/************************************************************
@@ -1846,7 +1842,6 @@ int migrate_misplaced_transhuge_page(struct mm_struct *mm,
18461842
}
18471843

18481844
mlock_migrate_page(new_page, page);
1849-
mem_cgroup_migrate(page, new_page);
18501845
page_remove_rmap(page, true);
18511846
set_page_owner_migrate_reason(new_page, MR_NUMA_MISPLACED);
18521847

0 commit comments

Comments
 (0)