Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to export into libolm pickles #95

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

poljar
Copy link
Collaborator

@poljar poljar commented Nov 30, 2022

No description provided.

@poljar poljar requested a review from dkasak November 30, 2022 12:31
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 87.58% // Head: 88.16% // Increases project coverage by +0.58% 🎉

Coverage data is based on head (b5dab00) compared to base (5ece305).
Patch coverage: 87.84% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   87.58%   88.16%   +0.58%     
==========================================
  Files          32       32              
  Lines        1603     1724     +121     
==========================================
+ Hits         1404     1520     +116     
- Misses        199      204       +5     
Impacted Files Coverage Δ
src/lib.rs 86.66% <ø> (-13.34%) ⬇️
src/olm/session_keys.rs 0.00% <ø> (ø)
src/sas.rs 94.64% <ø> (ø)
src/utilities/mod.rs 98.00% <ø> (ø)
src/olm/session/chain_key.rs 92.30% <25.00%> (-1.98%) ⬇️
src/olm/session/ratchet.rs 81.48% <25.00%> (-1.13%) ⬇️
src/olm/session/root_key.rs 96.42% <50.00%> (-3.58%) ⬇️
src/olm/account/mod.rs 90.25% <82.85%> (-2.18%) ⬇️
src/olm/session/mod.rs 90.24% <88.88%> (+6.11%) ⬆️
src/megolm/group_session.rs 95.83% <100.00%> (+0.48%) ⬆️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@poljar poljar force-pushed the poljar/libolm-pickle-encode-support branch from e22170d to cbae68b Compare November 30, 2022 14:28
@dkasak
Copy link
Member

dkasak commented Dec 28, 2022

We also need to update the README to remove the notice that libolm pickle support is "read-only".

@nico-famedly
Copy link

Is there anything blocking this or something I could help to push this forward? I would like to support both libolm and vodozemac for a while in our SDK and if it was possible to switch between both, that would make a few things easier until we migrate away from libolm entirely.

@poljar
Copy link
Collaborator Author

poljar commented Feb 13, 2023

Is there anything blocking this or something I could help to push this forward? I would like to support both libolm and vodozemac for a while in our SDK and if it was possible to switch between both, that would make a few things easier until we migrate away from libolm entirel

I think it's just a lack of time due to a FOSDEM crunch.

Beware that the transition from libolm to vodozemac is losless, but vodozemac has larger buffers for one-time keys and some other objects.

This makes the transition from vodozemac back to libolm lossy.

@nico-famedly
Copy link

Beware that the transition from libolm to vodozemac is losless, but vodozemac has larger buffers for one-time keys and some other objects.

Yes, I am aware and partially documented it already internally. We generally wouldn't want to transition back, but we want to somewhat gracefully handle the cases where someone might start an older version of the app and similar for a while.

I think it's just a lack of time due to a FOSDEM crunch.

Okay, that sounds absolutely fair. I was mostly just thinking this would be useful for me during the migration and wanted to make sure it couldn't use some help. Thank you for the reply!

src/lib.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants