Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to export an Account to a libolm pickle #111

Merged
merged 4 commits into from
Aug 4, 2023

Conversation

poljar
Copy link
Collaborator

@poljar poljar commented Aug 4, 2023

Split out from #95, contains only the support to pickle Accounts.

This is mostly needed for dehydrated devices, and should make landing #95
easier.

@poljar poljar force-pushed the poljar/account-libolm-pickle-support branch from e6e6f6e to d87d472 Compare August 4, 2023 08:48
@poljar poljar requested a review from dkasak August 4, 2023 08:53
Copy link
Member

@dkasak dkasak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some concerns around zeroization but otherwise looks good. Also spelled out the security issue with pickle keys in more detail. When these are addressed, this turns into an approve.

src/olm/account/mod.rs Outdated Show resolved Hide resolved
src/olm/account/mod.rs Outdated Show resolved Hide resolved
src/olm/account/mod.rs Outdated Show resolved Hide resolved
src/olm/account/mod.rs Outdated Show resolved Hide resolved
src/olm/account/mod.rs Outdated Show resolved Hide resolved
@poljar poljar enabled auto-merge (squash) August 4, 2023 13:10
@poljar poljar merged commit e3b6585 into main Aug 4, 2023
@poljar poljar deleted the poljar/account-libolm-pickle-support branch August 4, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants