Real non-joined user can call /events on world_readable room is flaky

[richvdh]

see https://github.com/matrix-org/synapse/pull/10558/checks?check_run_id=3281591362

[DMRobertson]

And https://github.com/matrix-org/synapse/pull/11026/checks?check_run_id=3862104930

[DMRobertson]

And https://github.com/matrix-org/synapse/runs/6192979209?check_suite_focus=true

[clokep]

https://github.com/matrix-org/synapse/actions/runs/4385567896/jobs/7678532027

[DMRobertson]

And my axe https://github.com/matrix-org/synapse/actions/runs/4387381343/jobs/7682681955

[clokep]

Seem to have been getting this a bit lately: https://github.com/matrix-org/synapse/actions/runs/4429959916/jobs/7771215660

[DMRobertson]

And https://github.com/matrix-org/synapse/actions/runs/4489600014/jobs/7895717701?pr=15309

[richvdh]

https://github.com/matrix-org/synapse/actions/runs/4491633509/jobs/7900506858?pr=15128

[squahtx]

This test is failing randomly because it's hitting the 10 second test timeout. We'll want to find out why /events is taking half a second per request and possibly raise the test timeout if it's unfixable. is always timing out and not returning what the test is expecting.

https://github.com/matrix-org/synapse/actions/runs/4491633509/jobs/7900506858?pr=15128

  # Started: 2023-03-22 15:54:37.343
  # Ended: 2023-03-22 15:54:47.732
  # Timed out waiting for test at /sytest/run-tests.pl line 864.
  # 0.163640: Registered new user @anon-20230322_154851-242:localhost:8839
  # 0.383248: Registered new user @anon-20230322_154851-243:localhost:8839
  # 0.384377: Registered new user @anon-20230322_154851-244:localhost:8839
  # 1.143053: room_id=!BZmYIrDwrrYmdhWhAF:localhost:8839
  # 1.143245: Created room_id=!BZmYIrDwrrYmdhWhAF:localhost:8839
  # 1.557948: Sent 'm.room.message' event in !BZmYIrDwrrYmdhWhAF:localhost:8839: $eyd8Vm4m9omi-Q09cE7J1ys0vWec3tTf85orUKJjUsk
  # 2.012173: GET_new_events_for @anon-20230322_154851-242:localhost:8839:
  # {
  #   chunk => [],
  #   end   => "s1330_189_6_7_3_1_1_322_0_2",
  #   start => "s1330_189_6_7_3_1_1_322_0_2",
  # }
  # 2.611808: GET_new_events_for @anon-20230322_154851-242:localhost:8839:
  # {
  #   chunk => [],
  #   end   => "s1330_189_6_7_3_1_1_322_0_2",
  #   start => "s1330_189_6_7_3_1_1_322_0_2",
  # }
  # 3.092511: GET_new_events_for @anon-20230322_154851-242:localhost:8839:
  # {
  #   chunk => [],
  #   end   => "s1330_189_6_7_3_1_1_322_0_2",
  #   start => "s1330_189_6_7_3_1_1_322_0_2",
  # }
  # 3.600925: GET_new_events_for @anon-20230322_154851-242:localhost:8839:
  # {
  #   chunk => [],
  #   end   => "s1330_189_6_7_3_1_1_322_0_2",
  #   start => "s1330_189_6_7_3_1_1_322_0_2",
  # }
  # 4.200933: GET_new_events_for @anon-20230322_154851-242:localhost:8839:
  # {
  #   chunk => [],
  #   end   => "s1330_189_6_7_3_1_1_322_0_2",
  #   start => "s1330_189_6_7_3_1_1_322_0_2",
  # }
  # 4.726515: GET_new_events_for @anon-20230322_154851-242:localhost:8839:
  # {
  #   chunk => [],
  #   end   => "s1330_189_6_7_3_1_1_322_0_2",
  #   start => "s1330_189_6_7_3_1_1_322_0_2",
  # }
  # 5.254974: GET_new_events_for @anon-20230322_154851-242:localhost:8839:
  # {
  #   chunk => [],
  #   end   => "s1330_189_6_7_3_1_1_322_0_2",
  #   start => "s1330_189_6_7_3_1_1_322_0_2",
  # }
  # 5.861244: GET_new_events_for @anon-20230322_154851-242:localhost:8839:
  # {
  #   chunk => [],
  #   end   => "s1330_189_6_7_3_1_1_322_0_2",
  #   start => "s1330_189_6_7_3_1_1_322_0_2",
  # }
  # 6.389159: GET_new_events_for @anon-20230322_154851-242:localhost:8839:
  # {
  #   chunk => [],
  #   end   => "s1330_189_6_7_3_1_1_322_0_2",
  #   start => "s1330_189_6_7_3_1_1_322_0_2",
  # }
  # 6.920921: GET_new_events_for @anon-20230322_154851-242:localhost:8839:
  # {
  #   chunk => [],
  #   end   => "s1330_189_6_7_3_1_1_322_0_2",
  #   start => "s1330_189_6_7_3_1_1_322_0_2",
  # }
  # 7.486544: GET_new_events_for @anon-20230322_154851-242:localhost:8839:
  # {
  #   chunk => [],
  #   end   => "s1330_189_6_7_3_1_1_322_0_2",
  #   start => "s1330_189_6_7_3_1_1_322_0_2",
  # }
  # 8.025035: GET_new_events_for @anon-20230322_154851-242:localhost:8839:
  # {
  #   chunk => [],
  #   end   => "s1330_189_6_7_3_1_1_322_0_2",
  #   start => "s1330_189_6_7_3_1_1_322_0_2",
  # }
  # 8.542043: GET_new_events_for @anon-20230322_154851-242:localhost:8839:
  # {
  #   chunk => [],
  #   end   => "s1330_189_6_7_3_1_1_322_0_2",
  #   start => "s1330_189_6_7_3_1_1_322_0_2",
  # }
  # 9.068112: GET_new_events_for @anon-20230322_154851-242:localhost:8839:
  # {
  #   chunk => [],
  #   end   => "s1330_189_6_7_3_1_1_322_0_2",
  #   start => "s1330_189_6_7_3_1_1_322_0_2",
  # }
  # 9.675062: GET_new_events_for @anon-20230322_154851-242:localhost:8839:
  # {
  #   chunk => [],
  #   end   => "s1330_189_6_7_3_1_1_322_0_2",
  #   start => "s1330_189_6_7_3_1_1_322_0_2",
  # }
  # 10.260006: GET_new_events_for @anon-20230322_154851-242:localhost:8839:
  # {
  #   chunk => [],
  #   end   => "s1330_189_6_7_3_1_1_322_0_2",
  #   start => "s1330_189_6_7_3_1_1_322_0_2",
  # }
Totals: 827 passed, 11 expected fail, 1 failed

[clokep]

Again: https://github.com/matrix-org/synapse/actions/runs/4564029418/jobs/8053299206?pr=15321

Looks like @squahtx has a fix though! 🎉