Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix backfilled events being rejected for no state_groups #10439

Merged
merged 17 commits into from
Jul 29, 2021
Merged

Fix backfilled events being rejected for no state_groups #10439

merged 17 commits into from
Jul 29, 2021

Commits on Jul 21, 2021

  1. Fix backfilled events being rejected for none state_groups 

    Reproducible on a federated homeserver when there is a membership auth event as a floating outlier. Then when we try to backfill one of that persons messages, it has missing membership auth to fetch which caused us to mistakenly replace the `context` for the message with that of the floating membership `outlier` event. Since `outliers` have no `state` or `state_group`, the error bubbles up when we continue down the persisting route: `sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group`

Call stack:

```
backfill
_auth_and_persist_event
_check_event_auth
_update_auth_events_and_context_for_auth
```
    @MadLittleMods
    MadLittleMods committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    2db287e View commit details
    Browse the repository at this point in the history

  2. Fix 403

    @MadLittleMods
    MadLittleMods committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    28a5e6a View commit details
    Browse the repository at this point in the history

  3. Some more cleanup and try backfill

    @MadLittleMods
    MadLittleMods committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    64c8e5e View commit details
    Browse the repository at this point in the history

  4. Reproduce problem

    @MadLittleMods
    MadLittleMods committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    e9f3e9d View commit details
    Browse the repository at this point in the history

  5. Reproduce without join_rule cheat

    @MadLittleMods
    MadLittleMods committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    487247f View commit details
    Browse the repository at this point in the history

  6. Add fix back

    @MadLittleMods
    MadLittleMods committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    b1ce3af View commit details
    Browse the repository at this point in the history

  7. Clean up all the debug logs

    @MadLittleMods
    MadLittleMods committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    005382f View commit details
    Browse the repository at this point in the history

  8. Remove logs from tests

    @MadLittleMods
    MadLittleMods committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    87b7fb9 View commit details
    Browse the repository at this point in the history

  9. Add changelog

    @MadLittleMods
    MadLittleMods committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    a94217e View commit details
    Browse the repository at this point in the history

  10. Remove unused mock

    @MadLittleMods
    MadLittleMods committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    b2e26b9 View commit details
    Browse the repository at this point in the history

  11. Run linters

    @MadLittleMods
    MadLittleMods committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    b0886f8 View commit details
    Browse the repository at this point in the history

  12. Fix lints

    @MadLittleMods
    MadLittleMods committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    eb32018 View commit details
    Browse the repository at this point in the history

  13. Merge remote-tracking branch 'origin/develop' into madlittlemods/fix-… 

    …context-from-being-wrecked-when-backfilling
    @erikjohnston
    erikjohnston committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    1e97096 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2021

  1. Merge branch 'develop' into madlittlemods/fix-context-from-being-wrec… 

    …ked-when-backfilling
    @MadLittleMods
    MadLittleMods committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    3ca36c9 View commit details
    Browse the repository at this point in the history

  2. Create test events with an event builder

    @MadLittleMods
    MadLittleMods committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    16b113b View commit details
    Browse the repository at this point in the history

  3. Clarify what the test is actually doing

    @MadLittleMods
    MadLittleMods committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    a89a95f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into madlittlemods/fix-context-from-being-wrec… 

    …ked-when-backfilling
    @MadLittleMods
    MadLittleMods committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    287b32c View commit details
    Browse the repository at this point in the history