Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Feature to disable push notifications entirely #9524

Closed
Half-Shot opened this issue Mar 2, 2021 · 2 comments · Fixed by #14551
Closed

Feature to disable push notifications entirely #9524

Half-Shot opened this issue Mar 2, 2021 · 2 comments · Fixed by #14551
Labels
A-Application-Service Related to AS support A-Push Issues related to push/notifications T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@Half-Shot
Copy link
Collaborator

I'm looking at the Gitter homeserver, and we could probably afford to make some savings by not bothering to calculate push actions:

2021-03-02 00:01:10,260 - synapse.storage.databases.main.event_push_actions - 785 - INFO - rotate_notifs-233- Rotating notifications, handling 8343 rows

I imagine there are situations where push isn't important, so some sort of config flag (maybe push.enabled?) that just exits early when calculating push actions?

@clokep
Copy link
Member

clokep commented Mar 2, 2021

Maybe setting start_pushers: False will help with this (see https://github.com/matrix-org/synapse/blob/master/docs/workers.md#synapseapppusher)? I'm not sure this is really supported to just disable push though.

@clokep clokep added the X-Needs-Info This issue is blocked awaiting information from the reporter label Mar 2, 2021
@Half-Shot
Copy link
Collaborator Author

I think that will stop sending push notifs, but I think we still queue them in the DB? This is mostly about trying to save work involving push.

@clokep clokep added T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. and removed X-Needs-Info This issue is blocked awaiting information from the reporter labels Mar 2, 2021
@MadLittleMods MadLittleMods added A-Push Issues related to push/notifications A-Application-Service Related to AS support labels Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Application-Service Related to AS support A-Push Issues related to push/notifications T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants