Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Pin flake8 to minor version #9500

Closed
ShadowJonathan opened this issue Feb 26, 2021 · 2 comments
Closed

Pin flake8 to minor version #9500

ShadowJonathan opened this issue Feb 26, 2021 · 2 comments
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@ShadowJonathan
Copy link
Contributor

Related to #9366

When talking about #9370, the issue of missing out on new features was dropped, when i was looking at the codebase again when working on #9499, i saw that flake8 had an unbound dependency constraint.

We could start having a similar problem like black, where a new version adding in new checks would break CI for a hot minute, because the current codebase does not match up with the lint's required checks.

This'd require taking notice of flake8 manually to update each minor version, but i think i can automate such things (i'm currently looking at https://github.com/dependabot/dependabot-script)

@ShadowJonathan
Copy link
Contributor Author

dependabot/dependabot-core#3202 is sorta related to this, need to fix that before detection of dependencies is possible in the first place, it seems

@clokep clokep added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Feb 26, 2021
@DMRobertson
Copy link
Contributor

Synapse now maintains a poetry lock file, and uses this to populate CI with pinned versions. (#11537)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

No branches or pull requests

3 participants