Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

support for SSO via twitter #9389

Closed
richvdh opened this issue Feb 11, 2021 · 2 comments · Fixed by #14778
Closed

support for SSO via twitter #9389

richvdh opened this issue Feb 11, 2021 · 2 comments · Fixed by #14778
Assignees
Labels
A-Social Login Login via external identity providers S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@richvdh
Copy link
Member

richvdh commented Feb 11, 2021

Twitter use OAuth1, so this is a pain.

@richvdh richvdh added A-Social Login Login via external identity providers S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. labels Feb 11, 2021
@clokep
Copy link
Member

clokep commented Dec 29, 2022

Twitter use OAuth1, so this is a pain.

Note that Twitter does support OAuth 2.0 now:

We need some changes on our side to handle it (mostly RFC7636 support). I'll take a look at this.

@clokep clokep self-assigned this Dec 29, 2022
@clokep
Copy link
Member

clokep commented Dec 29, 2022

This also has the same issues as #8511 where the userinfo endpoint puts everything under a data map.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Social Login Login via external identity providers S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants