Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Support for https traffic to the proxy #9090

Closed
Bubu opened this issue Jan 12, 2021 · 3 comments · Fixed by #10411
Closed

Support for https traffic to the proxy #9090

Bubu opened this issue Jan 12, 2021 · 3 comments · Fixed by #10411
Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@Bubu
Copy link
Contributor

Bubu commented Jan 12, 2021

Description:

Note: this is different from talking https via the proxy (via HTTPS_PROXY). This is about supporting https for the synapse -> proxy-server connection.

From what I understand this feature is not that widely supported yet (though the article below is from 2016). But for complete proxy support for synapse this might be worth adding.

Context: https://daniel.haxx.se/blog/2016/11/26/https-proxy-with-curl/

@Bubu
Copy link
Contributor Author

Bubu commented Jan 12, 2021

There's a comment about this here: https://github.com/matrix-org/synapse/blob/develop/synapse/http/proxyagent.py#L187-L189

# currently we only support hostname:port. Some apps also support
# protocol://<host>[:port], which allows a way of requiring a TLS connection to the
# proxy.

@Bubu
Copy link
Contributor Author

Bubu commented Jan 13, 2021

I have a working commit for this now: https://git.bubu1.eu/Bubu/synapse/-/commit/d7c77ce51ed002af94316c1c277c0d020cd26368

Need to add tests, etc.

@anoadragon453 anoadragon453 added the T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. label Feb 1, 2021
@anoadragon453
Copy link
Member

This looks promising, thanks @Bubu! In-progress PR is here: #9119

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
2 participants