Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Improve CI testing of portdb script #8392

Open
erikjohnston opened this issue Sep 24, 2020 · 2 comments
Open

Improve CI testing of portdb script #8392

erikjohnston opened this issue Sep 24, 2020 · 2 comments
Labels
A-Portdb Script for exporting sqlite data into postgres O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@erikjohnston
Copy link
Member

erikjohnston commented Sep 24, 2020

Edit: original title was "Add check to CI that sequences are correctly ported by port script"

c.f. #8387

@erikjohnston
Copy link
Member Author

It would be good to fix a more general thing which is that we don't currently check that the ported DB is usable. Some things that we can do are:

  1. Ensure that a server can successfully start up using the ported DB
  2. Ensure that we can register/login/create room/send event, which should check the most common code paths
  3. Run the unit tests or SyTest using the ported DB as a base

@DMRobertson DMRobertson added S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. A-Portdb Script for exporting sqlite data into postgres O-Occasional Affects or can be seen by some users regularly or most users rarely and removed z-maintenance labels Aug 25, 2022
@DMRobertson DMRobertson changed the title Add check to CI that sequences are correctly ported by port script Improve CI testing of portdb script Aug 25, 2022
@DMRobertson
Copy link
Contributor

DMRobertson commented Aug 25, 2022

#13226 fixed a particularly gnarly bug where portdb was capable of dropping rows with negative row IDs.

A check e.g. that SELECT count(*) FROM <tablename> queries were consistent between sqlite and postgres would have spotted the problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Portdb Script for exporting sqlite data into postgres O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

No branches or pull requests

3 participants