Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Shard Client Reader for registration #7672

Closed
neilisfragile opened this issue Jun 10, 2020 · 4 comments · Fixed by #7830
Closed

Shard Client Reader for registration #7672

neilisfragile opened this issue Jun 10, 2020 · 4 comments · Fixed by #7830
Assignees
Labels
A-Performance Performance, both client-facing and admin-facing

Comments

@neilisfragile
Copy link
Contributor

No description provided.

@neilisfragile neilisfragile added p1 A-Performance Performance, both client-facing and admin-facing labels Jun 10, 2020
@erikjohnston erikjohnston changed the title Shard Client Reader Shard Client Reader for registeration Jun 11, 2020
@erikjohnston
Copy link
Member

erikjohnston commented Jun 11, 2020

Next steps: We think that we can already do this now that sessions are persisted to the database, but we should test and double check this is true. Ideally we'd also add some unit tests to assert that registration works if you switch workers half way through

@richvdh richvdh changed the title Shard Client Reader for registeration Shard Client Reader for registration Jun 11, 2020
@richvdh
Copy link
Member

richvdh commented Jun 25, 2020

to be clear: we already have multiple client readers; this task is to remove the rules in haproxy that pin registration requests to a single instance.

@clokep
Copy link
Member

clokep commented Jul 10, 2020

I believe that #7530 is related to this, although that's specific to using SAML.

@clokep clokep self-assigned this Jul 10, 2020
@clokep
Copy link
Member

clokep commented Jul 13, 2020

@erikjohnston had a couple more thoughts on this:

FYI on the client reader sharding the first step might be to look at the federation sharding test and steal the logic for running multiple workers, and then do a registration flow against them but change which worker you speak to each time

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Performance Performance, both client-facing and admin-facing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants