Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Ignore sending PUSH notifications for muted rooms #7432

Closed
MurzNN opened this issue May 6, 2020 · 5 comments
Closed

Ignore sending PUSH notifications for muted rooms #7432

MurzNN opened this issue May 6, 2020 · 5 comments

Comments

@MurzNN
Copy link

MurzNN commented May 6, 2020

At now, as I understand, Synapse sends PUSH notifications for all new messages, even if room is muted. This way unnecessary eats battery&traffic on mobile devices, because users not often reads muted rooms. So sending only one first PUSH for make room "bold" on new unread message is enough for most users.

Can we add feature to disable sending unnecessary PUSH notifications to devices from muted rooms? Related Riot issue is element-hq/element-web#7438

@babolivier
Copy link
Contributor

Synapse only sends notifications for rooms that it's configured to do so. Messages in muted rooms shouldn't cause notifications to be sent.

Are you saying you're seeing push notifs for muted rooms?

@babolivier
Copy link
Contributor

Also the client figures out whether to bold a room from data it receives through sync, not push notifications. I don't remember the specifics, but I believe the Riot mobile clients sync when you're using them as well as whenever they receive a push notif (which, again, should only be sent when a message is sent to a room configured to notify you).

@MurzNN
Copy link
Author

MurzNN commented May 6, 2020

The main problem is that RiotX eats too much battery between 24 hours, even if I not use it and don't receive any new message from not muted rooms in this day. And I understand, that this is because it wakes up on PUSH'es from muted rooms.

If Synapse works like described, seems the source of problem is not in this place.

Is there any ways to debug or count sent push notifications to device on server/client side?

@MurzNN
Copy link
Author

MurzNN commented May 6, 2020

I found this in Synapse logs:

Processing 1 unprocessed push actions for @user:homeserver.org

So seems yes, on Synapse side all works well. I close issue.

@MurzNN MurzNN closed this as completed May 6, 2020
@babolivier
Copy link
Contributor

babolivier commented May 6, 2020

Cool then :)
FYI, the issue about RiotX being very hungry on the battery is element-hq/element-android#536

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants