Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Appservice API does not recieve full unsigned content #4268

Closed
Tracked by #3506
Half-Shot opened this issue Dec 6, 2018 · 2 comments
Closed
Tracked by #3506

Appservice API does not recieve full unsigned content #4268

Half-Shot opened this issue Dec 6, 2018 · 2 comments
Labels
A-Application-Service Related to AS support A-Spec-Compliance places where synapse does not conform to the spec T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. z-bug (Deprecated Label) z-p2 (Deprecated Label)

Comments

@Half-Shot
Copy link
Collaborator

Half-Shot commented Dec 6, 2018

Down a sync request I receive:

  "unsigned": {
    "replaces_state": "$1533932569110hPnSg:half-shot.uk",
    "prev_content": {
      "membership": "join",
      "avatar_url": "mxc://half-shot.uk/db7ed219580a58e65d1b84c0bab1d78e",
      "displayname": "cough",
      "uk.half-shot.discord.member": {
        "id": "145545543043645440",
        "roles": [
          {
            "color": 0,
            "position": 0,
            "name": "@everyone"
          }
        ]
      }
    }

and in an appservice transaction I get:

  "unsigned": {
    "age": 500
    "replaces_state": "$1533932569110hPnSg:half-shot.uk",
    },
@turt2live
Copy link
Member

in case there's any question about which is right: the appservice should be receiving them in the same format as a client.

See https://matrix.org/docs/spec/application_service/r0.1.0.html#put-matrix-app-v1-transactions-txnid

Parameter Type Description
JSON body parameters
events [Event] Required. A list of events, formatted as per the Client-Server API.

@neilisfragile neilisfragile added z-p2 (Deprecated Label) z-bug (Deprecated Label) labels Dec 17, 2018
@clokep clokep added the A-Spec-Compliance places where synapse does not conform to the spec label Apr 29, 2020
@MadLittleMods MadLittleMods added A-Application-Service Related to AS support T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. labels Sep 4, 2021
@richvdh
Copy link
Member

richvdh commented Oct 14, 2021

so you're missing prev_content. This is as currently specced, though I want to do something about it: matrix-org/matrix-spec-proposals#877.

@richvdh richvdh closed this as completed Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Application-Service Related to AS support A-Spec-Compliance places where synapse does not conform to the spec T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. z-bug (Deprecated Label) z-p2 (Deprecated Label)
Projects
None yet
Development

No branches or pull requests

6 participants