Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

SRV records aren't handled properly #4104

Closed
jcgruenhage opened this issue Oct 29, 2018 · 3 comments
Closed

SRV records aren't handled properly #4104

jcgruenhage opened this issue Oct 29, 2018 · 3 comments
Labels
A-Performance Performance, both client-facing and admin-facing z-p2 (Deprecated Label)

Comments

@jcgruenhage
Copy link
Contributor

Description

As described here in the code, load balancing and failover using SRV records doesn't work properly in Synapse.
@jcgruenhage
Copy link
Contributor Author

That comment mentions that load balancing is broken and that synapse fails over to lower priority servers without the higher priority servers actually being down. Testing with tulir seemed to indicate that failover when a higher priority server is actually down doesn't work either, but I haven't found an explanation for that in the code and I haven't spent more time trying to reproduce it. Hopefully that will just go away with this piece of the code being reworked.

@neilisfragile neilisfragile added A-Performance Performance, both client-facing and admin-facing z-p2 (Deprecated Label) labels Nov 8, 2018
@jcgruenhage jcgruenhage mentioned this issue Nov 12, 2018
Merged
@jcgruenhage
Copy link
Contributor Author

Update: Load balancing works now, failover doesn't yet.

@richvdh
Copy link
Member

richvdh commented Sep 19, 2019

I think this was fixed in #5864

@richvdh richvdh closed this as completed Sep 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Performance Performance, both client-facing and admin-facing z-p2 (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@neilisfragile @richvdh @jcgruenhage