Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Joining by invite to empty room #3602

Closed
slipeer opened this issue Jul 25, 2018 · 2 comments
Closed

Joining by invite to empty room #3602

slipeer opened this issue Jul 25, 2018 · 2 comments

Comments

@slipeer
Copy link
Contributor

slipeer commented Jul 25, 2018

Problem reproduction

If user A has invited user B to a new room, but he did not wait when B accenpt invite and leave room.
User B see invite, but when trying to accept it, the error "no known servers"

I believe that synapse must more correct handle this situation:

  • for example return error like "everyone left the room".
  • or accept user join into room in which there is already no one (maybe there are messages for user).

Second variant of behavior seems more logical to me.

Probably requires changes in _is_host_in_room method in synapse/handlers/room_member.py - this method return false if all local users leave room.

This method is called from _update_membership (same handler) and if it return False then used method _remote_join. I think that call to _remote_join is not entirely correct whent local user try to join local room in which there is already no one.

@richvdh
Copy link
Member

richvdh commented Jul 25, 2018

@ara4n
Copy link
Member

ara4n commented Sep 12, 2020

Another solution would be to for the invite to be cancelled when the inviter leaves, as per https://github.com/matrix-org/matrix-doc/issues/1966

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants